feat: Set $feature_flag_error on $feature_flag_called#86
Merged
dustinbyrne merged 3 commits intomainfrom Dec 19, 2025
Merged
Conversation
If an error occurs while fetching flags, the property will be set to indicate what happened.
dustinbyrne
force-pushed
the
feat/feature-flag-error
branch
from
bccd3ac to
c3c405a
Compare
Considering it can be a string
gustavohstrassburger
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds observability into feature flag evaluation failures by including a
$feature_flag_errorproperty on$feature_flag_calledevents. The error types are:Timeout::Error,Net::ReadTimeout,Net::WriteTimeout)ECONNREFUSED,ECONNRESET,SocketError)errorsWhileComputingFlags: trueapi_error_500,api_error_503)Multiple errors can occur simultaneously and are joined with commas (e.g.,
errors_while_computing_flags,flag_missing).